vote: use InvalidAccountData for v0_23_5 vsv deserializing
#447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
approved these changes
Nov 19, 2025
Contributor
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Originally I did this on purpose, since we decided v0 accounts would be treated as uninitialized, since they're phased out.
We can either do this here, to align with the v3 and v4 deserializers...
...or we can use UnitializedAccount everywhere.
I suppose InvalidAccountData is closer to the actual case itself - the account layout is invalid, because it's been phased out. I vote ship it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FD, we have
get_state()implemented and used instead of implementing Agave's custom deserializers for vote states. To simplify the deserialization logic,InvalidAccountDatashould be thrown to match the error semantics ofget_state()in fuzz-generated cases where v0_23_5 vote accounts have invalid data.